Skip to content

rename integer literal type and float literal type #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andrewrk opened this issue Oct 21, 2017 · 0 comments · Fixed by #1057
Closed

rename integer literal type and float literal type #556

andrewrk opened this issue Oct 21, 2017 · 0 comments · Fixed by #1057
Labels
accepted This proposal is planned. breaking Implementing this issue could cause existing code to no longer compile or have different behavior. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Milestone
0.3.0

Comments

@andrewrk
Copy link
Member

andrewrk commented Oct 21, 2017 •
edited
Loading

Right now,

  • @typeName(@typeOf(1)) is "(integer literal)"
  • @typeName(@typeOf(1.0)) is "(float literal)"

I propose that these are renamed to comptime_int and comptime_float respectively. You would be able to refer to the types directly by name.

Also rename

  • @import("builtin").TypeId.FloatLiteral to ComptimeFloat
  • @import("builtin").TypeId.IntLiteral to ComptimeInt
  • @import("builtin").TypeId.UndefinedLiteral to Undefined
  • @import("builtin").TypeId.NullLiteral to Null
@andrewrk andrewrk added enhancement Solving this issue will likely involve adding new logic or components to the codebase. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. labels Oct 21, 2017
@andrewrk andrewrk added this to the 0.2.0 milestone Oct 21, 2017
@andrewrk andrewrk added accepted This proposal is planned. breaking Implementing this issue could cause existing code to no longer compile or have different behavior. and removed enhancement Solving this issue will likely involve adding new logic or components to the codebase. labels Dec 8, 2017
@andrewrk andrewrk mentioned this issue Feb 7, 2018
Open
@andrewrk andrewrk modified the milestones: 0.2.0, 0.3.0 Feb 28, 2018
@andrewrk andrewrk mentioned this issue May 4, 2018
Closed
@Hejsil Hejsil mentioned this issue Jun 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted This proposal is planned. breaking Implementing this issue could cause existing code to no longer compile or have different behavior. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Rename integer literal type and float literal type ziglang/zig
1 participant
@andrewrk