zig: expose linker options and include '-z notext' #10056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to allow the '-z notext' option to be passed to the linker via. the compiler frontend, which is a flag that tells the linker that relocations in read-only sections are permitted. Certain targets such as Solana BPF rely on this flag. Expose all linker options i.e. '-z nodelete', '-z now', '-z relro' in the compiler frontend. Usage documentation has been updated accordingly. Expose the '-z notext' flag in the standard library build runner.
kubkon
reviewed
Oct 29, 2021
| @@ -401,6 +401,14 @@ const usage_build_generic = | |||
| \\ -fno-allow-shlib-undefined Disallows undefined symbols in shared libraries | |||
| \\ --eh-frame-hdr Enable C++ exception handling by passing --eh-frame-hdr to linker | |||
| \\ --emit-relocs Enable output of relocation sections for post build tools | |||
| \\ -z [arg] Append linker arguments | |||
There was a problem hiding this comment.
Hmm, -z <arg> seems specific to ELF linkers; would it make more sense to expose each flag of interest separately with -fnotext or something similar? Also, we should definitely point out these are ELF-specific. @andrewrk I'd appreciate your look at this too!
There was a problem hiding this comment.
-z specifies an extension flag. wasm-ld supports them as well and we actually already make use of it to set the stack size for executables. So if we go with this, perhaps those should be supported too.
There was a problem hiding this comment.
Suggested change
| \\ -z [arg] Append linker arguments | |
| \\ -z [arg] Set linker extension flags |
andrewrk
approved these changes
Oct 29, 2021
| @@ -401,6 +401,14 @@ const usage_build_generic = | |||
| \\ -fno-allow-shlib-undefined Disallows undefined symbols in shared libraries | |||
| \\ --eh-frame-hdr Enable C++ exception handling by passing --eh-frame-hdr to linker | |||
| \\ --emit-relocs Enable output of relocation sections for post build tools | |||
| \\ -z [arg] Append linker arguments | |||
There was a problem hiding this comment.
Suggested change
| \\ -z [arg] Append linker arguments | |
| \\ -z [arg] Set linker extension flags |
| } else if (mem.eql(u8, arg, "-z")) { | ||
| i += 1; | ||
| if (i >= args.len) { | ||
| fatal("expected linker arg after '{s}'", .{arg}); |
There was a problem hiding this comment.
Suggested change
| fatal("expected linker arg after '{s}'", .{arg}); | |
| fatal("expected linker extension flag after '{s}'", .{arg}); |
|
Damn I was hoping github would let me make these changes before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to allow the '-z notext' option to be passed to the linker via. the compiler frontend, which is a flag that tells the linker that relocations in read-only sections are permitted. Certain targets such as Solana BPF rely on this flag.
Expose all linker options i.e. '-z nodelete', '-z now', '-z relro' in the compiler frontend. Usage documentation has been updated accordingly.
Expose the '-z notext' flag in the standard library build runner.