stage2 ARM: basic slice + basic struct support #10455
Conversation
| }); | ||
|
|
||
| // memcpy(src, dst, len) | ||
| try self.genArmInlineMemcpy(src_reg, dst_reg, len_reg, count_reg, tmp_reg); |
There was a problem hiding this comment.
Keep in mind that we also have the ability to call an external memcpy function if it makes sense to. It will be provided by libc, or in freestanding mode, zig provides a "freestanding libc" which has memcpy in it. Related: #7265
There was a problem hiding this comment.
Yes, in future, we should definitely do that. However, currently, extern function calls aren't supported by the Elf linking backend, so this is the best I could do 😆 . Also (this was @kubkon's idea) a potential for optimization is analyzing how often memcpy is needed and if e.g. memcpy is needed only once, it could be inlined, else emit calls to the extern memset.
| @@ -372,11 +372,32 @@ pub fn generateSymbol( | |||
| return Result{ .appended = {} }; | |||
| }, | |||
| .Struct => { | |||
| // TODO debug info | |||
| // TODO padding of struct members | |||
There was a problem hiding this comment.
I'll help with this in a future patch :)
There was a problem hiding this comment.
Thanks! It shouldn't be too hard as Type.structFieldOffset() already provides a lot of relevant information I think.
Further progress towards
zig test