windows: avoid runtime crash in fromSysTime #10720
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marler8997
force-pushed
the
windowsSysTime
branch
5 times, most recently
from
b728c41 to
bd824dd
Compare
A workaround for issue ziglang#10719. Removes the temporary i128 local variable `adjusted_epoch` which prevents the segfault from occuring. It's unclear as to why. See issue ziglang#10719 for more details.
marler8997
force-pushed
the
windowsSysTime
branch
from
bd824dd to
9f4095f
Compare
|
Closing in favor of the real fix here: #10729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: currently a draft because I may have a fix for the root cause soon
A workaround for issue #10719. Removes the temporary
i128local variableadjusted_epochwhich prevents a segfault from occuring on my machine. It's unclear as to why. See issue #10719 for more details.While I was editing this function I also added a bit of clarity in the doc comment to make it clear that "file time" was referring the SysTime in the function name
fromSysTime.