Fixed progress indicator for zig test
#10859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
requested changes
Feb 10, 2022
added 2 commits
February 11, 2022 00:57
Previously the progress displayed the first item as [0/x]. This was misleading when x is the number of items. The first item should be displayed as [1/x]
This was referenced Feb 13, 2022
Vexu
pushed a commit
that referenced
this pull request
Feb 14, 2022
In #10859 I moved the `test_node.end()` call after everything else has been logged. Now the `test_fn.name` is printed by `Progress` itself, making the additional log obsolete.
kubkon
pushed a commit
that referenced
this pull request
Feb 16, 2022
kubkon
pushed a commit
that referenced
this pull request
Feb 16, 2022
In #10859 I moved the `test_node.end()` call after everything else has been logged. Now the `test_fn.name` is printed by `Progress` itself, making the additional log obsolete.
|
This change introduces an inconsistency: When the last item being worked on is printed, the count will be one more than the total count, and so the line will briefly display something like I would propose to either revert the change on this line: Line 267 in 33cf6ef as the problem in the related issue seems to be fixed by the other parts of this change, or to replace the final value with some special indicator, like Progress [done].
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #10773
Now the progress always starts with 1. The counter is updated last, after every test related message has been printed.