Skip to content

Update the WASI libc to 30094b6ed05f19cee102115215863d185f2db4f0 #11864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

jedisct1
Copy link
Contributor

@jedisct1 jedisct1 commented Jun 14, 2022

Update our copy of wasi-libc up to commit 30094b6ed05f19cee102115215863d185f2db4f0 of the upstream repository.

@jedisct1 jedisct1 requested a review from kubkon June 14, 2022 12:06
@andrewrk
Copy link
Member

andrewrk commented Jun 14, 2022

Would you mind mentioning in the commit message the version number, git tag name, or sha1 of the wasi libc that this updates to?

Update our copy of wasi-libc up to the commit
30094b6ed05f19cee102115215863d185f2db4f0 from the upstream repository.
@jedisct1 jedisct1 changed the title Update the WASI libc Update the WASI libc to 30094b6ed05f19cee102115215863d185f2db4f0 Jun 14, 2022
Copy link
Member

@kubkon kubkon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One question though as I've not been keeping tabs on the libc development: have any new emulations been added that we should be aware of and potentially expose them as configurable build flags for wasi-libc? Thinking here of something like emulated-process-clocks, etc.

@jedisct1
Copy link
Contributor Author

I think the most recent emulation remains emulated-pid that we already had.

@kubkon
Copy link
Member

kubkon commented Jun 15, 2022

I think the most recent emulation remains emulated-pid that we already had.

Thanks @jedisct1!

@jedisct1
Copy link
Contributor Author

jedisct1 commented Jun 15, 2022

2022-06-15T00:38:17.8225490Z compiler [1074/1143] adding_numbers_at_runtime_and_comptime (stage2, x86_64-linux) [2/3] CBE: control flow failed: ChildProcessExecution
2022-06-15T00:38:17.8226360Z 1 tests failed

That doesn't smell good. But that doesn't seem to be related either.

@kubkon
Copy link
Member

kubkon commented Jun 15, 2022

2022-06-15T00:38:17.8225490Z compiler [1074/1143] adding_numbers_at_runtime_and_comptime (stage2, x86_64-linux) [2/3] CBE: control flow failed: ChildProcessExecution
2022-06-15T00:38:17.8226360Z 1 tests failed

That doesn't smell good. But that doesn't seem to be related either.

Yeah, I don't think this is related in any way. If you look at the CI state for current master we fail in linux CI also in incremental tests for no reason. I wonder if this is related to moving to running tests in parallel introduced in #11862

@kubkon kubkon merged commit d3caacf into ziglang:master Jun 15, 2022
@jedisct1 jedisct1 deleted the wasi-libc-update branch June 15, 2022 11:17
@andrewrk
Copy link
Member

That doesn't smell good. But that doesn't seem to be related either.

Fixed in 8caa206. Unfortunately there are two more bugs floating around that do not yet have reproducers:

I think the key move here is going to be investing in expanding on our debug infrastructure in order to diagnose these issues rather than trying to do some kind of heroic one-off debugging effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants