-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update the WASI libc to 30094b6ed05f19cee102115215863d185f2db4f0 #11864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Would you mind mentioning in the commit message the version number, git tag name, or sha1 of the wasi libc that this updates to? |
Update our copy of wasi-libc up to the commit 30094b6ed05f19cee102115215863d185f2db4f0 from the upstream repository.
9592c74
to
8c63037
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One question though as I've not been keeping tabs on the libc development: have any new emulations been added that we should be aware of and potentially expose them as configurable build flags for wasi-libc? Thinking here of something like emulated-process-clocks
, etc.
I think the most recent emulation remains |
Thanks @jedisct1! |
That doesn't smell good. But that doesn't seem to be related either. |
Yeah, I don't think this is related in any way. If you look at the CI state for current master we fail in linux CI also in incremental tests for no reason. I wonder if this is related to moving to running tests in parallel introduced in #11862 |
Fixed in 8caa206. Unfortunately there are two more bugs floating around that do not yet have reproducers:
I think the key move here is going to be investing in expanding on our debug infrastructure in order to diagnose these issues rather than trying to do some kind of heroic one-off debugging effort. |
Update our copy of wasi-libc up to commit 30094b6ed05f19cee102115215863d185f2db4f0 of the upstream repository.