stage2 fixes #11974
Merged
stage2 fixes #11974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regressed; the plan9 linker code is crashing when trying to build compiler-rt and we have no active plan9 maintainers involved in the Zig project. Anyone is welcome to come over and take the role; however, it's not one of the tier 1, 2, or 3 targets, so we will not be blocking progress towards 1.0 on plan9.
The constant value lowering for unions was missing a check for whether the payload was itself an unnamed struct. Lowerings of other types already handle this case. closes #11971
This can happen with pointers to zero-bit types. This commit fixes an LLVM assertion being tripped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this, behavior tests for x86_64-linux run clean on a debug LLVM; no assertions are tripped.
closes #11971
closes #11856