Skip to content

improve header searchlist handling in build, main #12898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

mikdusan
Copy link
Member

@mikdusan mikdusan commented Sep 18, 2022

build.zig:

  • use -I instead of -isystem for b.addSearchPrefix()

main.zig:

  • silently ignore superfluous search dirs
  • warn when a dir is added to multiple searchlists
  • consolidate "expected paramter after {s}" fatal error messages
  • rename command-line switch -dirafter-idirafter

closes #12888

@mikdusan mikdusan added zig build system std.Build, the build runner, `zig build` subcommand, package management zig cc Zig as a drop-in C compiler feature labels Sep 18, 2022
build.zig:
- use "-I" instead of "-isystem" for `b.addSearchPrefix()`

main.zig:
- silently ignore superfluous search dirs
- warn when a dir is added to multiple searchlists
- consolidate "expected paramter after {s}" fatal error messages
- rename command-line switch `-dirafter` → `-idirafter`

closes ziglang#12888
@matu3ba
Copy link
Contributor

matu3ba commented Sep 20, 2022

Does this also fix #11801 ?

@mikdusan
Copy link
Member Author

mikdusan commented Sep 20, 2022

Does this also fix #11801 ?

No, there are not any library search changes in this PR.

@andrewrk
Copy link
Member

Thanks @mikdusan!

@mikdusan mikdusan deleted the issue-12888 branch September 19, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zig build system std.Build, the build runner, `zig build` subcommand, package management zig cc Zig as a drop-in C compiler feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search path demotion for llvm headers when building self-hosted with custom llvm-dependency
3 participants