Add framework paths from NIX_CFLAGS_COMPILE #13467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
force-pushed
the
marco/add-nix-framework-paths
branch
from
d52de57 to
e6defd8
Compare
andrewrk
force-pushed
the
marco/add-nix-framework-paths
branch
from
e6defd8 to
9d6d705
Compare
Vexu
approved these changes
Jan 3, 2023
rrbutani
added a commit
to rrbutani/rosettaboy
that referenced
this pull request
Feb 8, 2023
This is needed for the nix package to build on macOS. Also bumps the zig deps and has `build.zig` changes to match ziglang/zig#14498 and ziglang/zig#14538.
jbboehr
pushed a commit
to jbboehr/rosettaboy
that referenced
this pull request
Feb 9, 2023
This is needed for the nix package to build on macOS. Also bumps the zig deps and has `build.zig` changes to match ziglang/zig#14498 and ziglang/zig#14538.
jbboehr
pushed a commit
to jbboehr/rosettaboy
that referenced
this pull request
Feb 10, 2023
This is needed for the nix package to build on macOS. Also bumps the zig deps and has `build.zig` changes to match ziglang/zig#14498 and ziglang/zig#14538.
jbboehr
pushed a commit
to jbboehr/rosettaboy
that referenced
this pull request
Feb 10, 2023
This is needed for the nix package to build on macOS. * bump the zig deps and has `build.zig` changes to match ziglang/zig#14498 and ziglang/zig#14538. * only change preInstall on darwin * drop the `SDL2` lowercase fix - doesn't appear to be necessary anymore. * upgrade zig in github actions and pass in nim/zig versions (@jbboehr)
jbboehr
pushed a commit
to jbboehr/rosettaboy
that referenced
this pull request
Feb 10, 2023
This is needed for the nix package to build on macOS. * bump the zig deps and has `build.zig` changes to match ziglang/zig#14498 and ziglang/zig#14538. * only change preInstall on darwin * drop the `SDL2` lowercase fix - doesn't appear to be necessary anymore. * upgrade zig in github actions and pass in nim/zig versions (@jbboehr)
jbboehr
pushed a commit
to jbboehr/rosettaboy
that referenced
this pull request
Feb 10, 2023
This is needed for the nix package to build on macOS. * bump the zig deps and has `build.zig` changes to match ziglang/zig#14498 and ziglang/zig#14538. * only change preInstall on darwin * drop the `SDL2` lowercase fix - doesn't appear to be necessary anymore. * upgrade zig in github actions and pass in nim/zig versions (@jbboehr)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS, if we're using Nix to supply the frameworks Zig should add the frameworks paths.
Instead we currently emit warning logs (which are a bit noisy). And then potentially fail to build. Users can workaround this by manually parsing the
NIX_CFLAGS_COMPILEand adding framework paths manually (basically what this PR does), but it would be great if we did the correct thing here.