Skip to content

windows: _tls_index linker error fixes #13569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

kcbanner
Copy link
Contributor

This should fix #8531 and #13549, which should fixup the CI for #13562 (which exposed this error).

There were three issues here:

@jedisct1
Copy link
Contributor

Yup, that fix works.

@Vexu Vexu linked an issue Nov 17, 2022 that may be closed by this pull request
@andrewrk andrewrk merged commit 88a0f3d into ziglang:master Nov 17, 2022
@xxxbxxx
Copy link
Contributor

xxxbxxx commented Nov 17, 2022

nice!
good catch with the extra _

@kcbanner kcbanner deleted the fix_tls_index_link branch January 8, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_tls_index vs tls_index for x86-windows LLD with LTO enabled incorrectly drops _tls_index symbol, causing undefined reference errors
4 participants