fs.Dir.deleteTree: Fix DirNotEmpty condition
#15402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`deleteTree` needs to retry once the directory is reported to be not empty. Otherwise, the retry condition is never reached.
Vexu
approved these changes
Apr 22, 2023
|
Nice catch, looks like a straight-up typo from me in 063c5f4. A test might be tricky to construct, as the relevant conditions would be something like:
Before this PR, it would not actually ever do the 'retry' part. After this PR, it will. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleteTreeneeds to retry once the directory is reported to be not empty. Otherwise,need_to_retryis always going to be false thus making the retry a dead code.