std: further windows resource fix #15460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addition to #15450
createFileW
does not account for whenLockFile
fails. This can result in a file handle not being closed on failure Which can be seen on test such asopen file with exclusive nonblocking lock twice
here:zig/lib/std/fs/test.zig
Lines 1030 to 1050 in d8bdfd8
this can also be observed by finding the file specified in the test in the
zig-cache
due to failure in cleanup.