Skip to content

@mem{cpy,set} fixes #15704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2023
Merged

@mem{cpy,set} fixes #15704

merged 3 commits into from
May 16, 2023

Conversation

Vexu
Copy link
Member

@Vexu Vexu commented May 14, 2023

Closes #15638, with parts being reused with attribution

@Vexu Vexu force-pushed the fix-memcpyset branch 2 times, most recently from 1433dbd to bbea91e Compare May 14, 2023 15:45
// :15:13: error: type '*u8' does not support indexing
// :15:13: note: operand must be an array, slice, tuple, or vector
// :10:13: error: type '*u8' is not an indexable pointer
// :10:13: note: operand must be a slice, a many pointer or a pointer to an array
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Destination may be a tuple, previous message was more correct

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding was that that hasn't been implemented yet #15479?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct, it's not implemented yet. It's fine to do as you have it, as long as you're aware 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a link to the issue next to the error message as a reminder.

@Vexu Vexu force-pushed the fix-memcpyset branch from 58d4522 to 0bc5e7b Compare May 15, 2023 07:31
@andrewrk andrewrk merged commit 4ba61a2 into ziglang:master May 16, 2023
@Vexu Vexu deleted the fix-memcpyset branch May 16, 2023 05:40
TUSF pushed a commit to TUSF/zig that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants