-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
zig cc: implement -###
(dry run)
#15738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note that it's still not compatible with how gcc/clang does things (and how Go expects them to be): This PR + #14462 yields:
|
I see, thank you for showing me this additional example. Looks like my small fix did not solve it when I'll let this commit through the pipeline as-is since it is an improvement from status quo, but I will make a follow-up enhancement to additionally support the case when the linker is involved. Unfortunately it will require adding a We may need to work with the Go team a little bit on this one - depending on what exactly Go is doing with the example linker line from a dry run, it may not work correctly. For example, if I look at this output from clang directly:
Here, it reports that
I fear that Go may decide that the linker is It would help to know what exactly Go is doing with the linker line printed via |
Ran the Go unit tests again. Looks like nothing — those Go unit tests that failed due to this flag before now pass. |
closes #7170
Before:
(exit code failure)
After:
(exit code success)