reduce garbage for repeated zig cc - calls
#15772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
force-pushed
the
stdin-hash
branch
from
8626cbd to
5ddcc7d
Compare
Context: user provides `-` to read from stdin instead of a file. Before: it would create a file in $ZIG_LOCAL_CACHE_DIR/tmp/ for each invocation and leave it there. After: it hashes the file contents and renames the file to the hash. Result: repeated invocations of `zig cc` do not cause so much trash to be created.
|
Sorry for the delay - I should have merged this a long time ago. I was sad to see the |
mlugg
reviewed
Mar 14, 2024
| // for the hashing algorithm here and in the cache are the same. | ||
| // We are providing our own cache key, because this file has nothing | ||
| // to do with the cache manifest. | ||
| var hasher = Cache.Hasher.init("0123456789abcdef"); |
There was a problem hiding this comment.
the purpose is for the file path to be a hash of the contents
There was a problem hiding this comment.
Yes, I know, but the string passed here is a seed, right? So it ought to be a hardcoded string of random bytes, like what std.Build.Cache.hasher_init does.
There was a problem hiding this comment.
random bytes, all zeroes, 123abc, it really doesn't matter. I think best would be using Cache.hasher_init.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: user provides
-to read from stdin instead of a file.Before: it would create a file in $ZIG_LOCAL_CACHE_DIR/tmp/ for each invocation and leave it there.
After: it hashes the file contents and renames the file to the hash.
Result: repeated invocations of
zig ccdo not cause so much trash to be created.