Add doc comment for tokenLocationPtr #1618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this is a comment change either a different change caused it to fail or flaky Appveyor. |
andrewrk
requested changes
Oct 2, 2018
std/zig/ast.zig
Outdated
| @@ -45,6 +45,7 @@ pub const Tree = struct { | |||
| line_end: usize, | |||
| }; | |||
|
|
|||
| /// Return the Location of the token relative to a line that starts at self.source[start_index]. | |||
There was a problem hiding this comment.
This is not quite right. It returns the location of the token relative to the offset specified by start_index.
|
The appveyor failure is #1363 |
The algorithm seemed unusual and I had spent some effort understanding it, so I thought I'd add a comment.
winksaville
force-pushed
the
add-doc-comment-for-tokenLocationPtr
branch
from
6663d64 to
afcc347
Compare
|
Txs for the correction, I said "line" because the Location returned is line oriented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The algorithm seemed unusual and I had spent some effort understanding
it, so I thought I'd add a comment.