Skip to content

crypto.tls.Client: fix occasional crash in readvAdvanced #16233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

jacobly0
Copy link
Member

@jacobly0 jacobly0 commented Jun 27, 2023

Fixes this crash:

thread 429064 panic: index out of bounds: index 16406, len 15054
lib/std/crypto/tls/Client.zig:1064:38: 0x14078bb in readvAdvanced__anon_149933 (zig)
            @memcpy(frag[first.len..][0..second_len], frag1[0..second_len]);
                                     ^
lib/std/crypto/tls/Client.zig:897:38: 0x14055f3 in readvAtLeast__anon_149932 (zig)
        var amt = try c.readvAdvanced(stream, iovecs[vec_i..]);
                                     ^
lib/std/crypto/tls/Client.zig:858:24: 0x14053af in readAtLeast__anon_149931 (zig)
    return readvAtLeast(c, stream, &iovecs, len);
                       ^

Maybe related #15723
Reproduced from #15814

@jedisct1 jedisct1 changed the title crypto: fix occasional crash in readvAdvanced crypto.tls.Client: fix occasional crash in readvAdvanced Jun 27, 2023
@andrewrk andrewrk merged commit d9e8671 into ziglang:master Jun 27, 2023
@jacobly0 jacobly0 deleted the tls branch June 27, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants