Skip to content

audit all contributions by @devnexen for correctness and delete unnecessary libc ABI bits #16636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 63 commits into from
Jul 31, 2023
Merged

audit all contributions by @devnexen for correctness and delete unnecessary libc ABI bits #16636

merged 63 commits into from
Jul 31, 2023

Conversation

andrewrk
Copy link
Member

Supersedes #16350.

Unfortunately, the vast majority of these commits were not up to standards and anything valuable from them must be re-done, this time with more testing, verification, and scrutiny. There are some places in the codebase where you can be sloppy, but OS ABI extern bits is not one of them.

Most of the APIs here should not go into the standard library even if correct.

andrewrk added 30 commits July 31, 2023 10:49
@andrewrk
Revert "std.c: fix haiku's find_path signature."
66d5f39 
This reverts commit 9e0ac44.
@andrewrk
Revert "std.c: msghdr* struct removing prefixes to match linux."
95e2605 
This reverts commit 8f14431.
@andrewrk
Revert "std.c: few freebsd's kinfo api fixes."
88b4ee1 
This reverts commit d07149c.
@andrewrk
Revert "std.c: fix few capcisum api calls, following-up on 6ae19fa."
381704d 
This reverts commit 72dd22f.
@andrewrk
Revert "std.c: fix host_basic_info definition for darwin."
0047113 
This reverts commit ea1d64d.
@andrewrk
Revert "std.c: freebsd fix typo for PROC.PROCCTL_MD_MIN constant."
643c986 
This reverts commit e9dd0a2.
@andrewrk
Revert "std.c: update netbsd/openbsd mman constants"
dad7eea 
This reverts commit 64f0059.
@andrewrk
Revert "Merge pull request #15867 from devnexen/haiku_malloc_usable_s…
8e9a33b 
…ize"

This reverts commit 3ef9123, reversing
changes made to 2839e35.
@andrewrk
Revert "std.c: exposing timer api"
9f20d01 
This reverts commit 54ea0bb.
@andrewrk
Revert "std.os: fix uname usage."
ba3b352 
This reverts commit 138f125.
@andrewrk
Revert "std.Thread: refining stack size from platform minimum, change…
1b9ffa0 
…s more targetted towards platform like Linux/musl (#15791)"

This reverts commit 41502c6.
@andrewrk
Revert "std.c: fix freebsd's CPU_ISSET call"
9d798ea 
This reverts commit 7689657.
@andrewrk
Revert "std.os: gethostname non libc linking using uname like linux"
aff65e7 
This reverts commit f8991ba.
@andrewrk
Revert "std.c: adding ptrace for netbsd."
43162ef 
This reverts commit ccfb0d4.
@andrewrk
Revert "std.os: add linux timer api"
833af38 
This reverts commit b9d2e0e.
@andrewrk
Revert "std.c: darwin's *copyfile api update."
faa6dae 
This reverts commit 40e8c22.
@andrewrk
Revert "std.c: add ptrace for freebsd support."
b7e37f9 
This reverts commit b754068.
@andrewrk
Revert "std.c: add netbsd's accept_filter_data for ACCEPT_FILTER sock…
a208c59 
… opt."

This reverts commit b677b36.
@andrewrk
Revert "std.c: add rfork for freebsd"
e1fdd21 
This reverts commit 2952fb9.
@andrewrk
Revert "std.os: implementing sched_setaffinity wrapper for freebsd"
86a5edc 
This reverts commit 05268bb.
@andrewrk
Revert "std.os: adding linux's sched_setaffinity and its wrapper"
182bec8 
This reverts commit c7bf8ba.
@andrewrk
Revert "linux adding some NUMA support"
8678d44 
This reverts commit 6f418c1.
@andrewrk
Revert "std.c: further darwin's host statistics data"
0043cdb 
This reverts commit cceadf5.
@andrewrk
Revert "std.c: adding basic darwin's host_statistics data."
942848d 
This reverts commit 6547d23.
@andrewrk
Revert "std.c: darwin adding more host_info api data"
f3fa47a 
This reverts commit 20cc693.
@andrewrk
Revert "std.c: adding freebsd's ioctl base operands."
6d7c6f4 
This reverts commit cd7e2bf.
@andrewrk
Revert "std.c: add freebsd's kinfo_vmobject"
ac7be71 
This reverts commit 5260657.
@andrewrk
Revert "std.c: adding freebsd's domainset_t bitset"
a048dda 
This reverts commit 10a7cf5.
@andrewrk
Revert "std.fs: selfExePath haiku using constants instead"
5d345b6 
This reverts commit e21739d.
@andrewrk
Revert "std.c: adding freebsd's domainset api"
8c7eb8c 
This reverts commit e8f76b4.
andrewrk added 21 commits July 31, 2023 11:17
@andrewrk
Revert "std.c:complete further more netbsd's mmap flags"
c9de530 
This reverts commit 4f248e1.
@andrewrk
Revert "std.c: add mincore api to darwin."
1f9161a 
This reverts commit 05f9608.
@andrewrk
Revert "std.c: adding mincore for freebsd"
ddd7b0e 
This reverts commit 8d88dcd.
@andrewrk
Revert "std.os: selfExePath implementation for haiku"
6bb776b 
This reverts commit 7439eb5.
@andrewrk
Revert "std.c: add find_path for haiku"
c6ec217 
This reverts commit 1084590.
@andrewrk
Revert "std.process: further totalSystemMemory portage"
70d1bb8 
This reverts commit 5c70d7b.
@andrewrk
Revert "std.os: sysctl* wrappers, better warning at compile time"
86388e3 
This reverts commit c66151a.
@andrewrk
Revert "std: adding sigevent to supported platforms."
5f101b2 
This reverts commit 23c4f55.
@andrewrk
Revert "std: adding FreeBSD's sched wrappers"
963b2a2 
This reverts commit 9ef6151.
@andrewrk
Revert "std: mcontext layout for x86 and fixing few x86_64 fields typ…
62deaaa 
…es for"

This reverts commit 9691cde.
@andrewrk
Revert "std: add accept_filter struct to make use of SO_ACCEPTFILTER …
aa5808c 
…socket option"

This reverts commit 1d322fe.
@andrewrk
Revert "std: add a subset of the macOs's libproc api."
c7f2a7e 
This reverts commit 7b0e015.
@andrewrk
Revert "std: enriching malloc api on freebsd."
a2439e1 
This reverts commit 9140249.
@andrewrk
Revert "std: adding netbsd's pthread to cpu affinity api"
1435359 
This reverts commit 3f259d3.
@andrewrk
Revert "os: expand sched_getaffinity wrapper and update freebsd's cpu…
b5df1bf 
…set api flags."

This reverts commit dbdafb6.
@andrewrk
Revert "std: adding freebsd's elf_aux_info api"
26777d9 
This reverts commit 83970b6.
@andrewrk
Revert "std: freebsd update proposal"
c0ac141 
This reverts commit 2568da2.
@andrewrk
Revert "std: add shm_create_largepage for FreeBSD, completing MFD* co…
a18a116 
…nstants."

This reverts commit 7b908e1.
@andrewrk
Revert "std add getrandom to solato solaris based systems"
68134e5 
This reverts commit 56d800f.
@andrewrk
Revert "std: add kinfo_vmentry for FreeBSD"
99c70ec 
This reverts commit 4a0508e.
@andrewrk
Revert "std: add FreeBSD's procctl api."
235b9fc 
This reverts commit 2e2d379.
@andrewrk andrewrk requested a review from kprotty as a code owner July 31, 2023 18:42
@andrewrk andrewrk mentioned this pull request Jul 31, 2023
Closed
andrewrk added 3 commits July 31, 2023 11:51
@andrewrk
std.c.openbsd: add ucontext_t for aarch64
b1bde35 
Reapplies 1585ed6 which was reverted in
f3adbe2.

I removed use of `usingnamespace` in this commit.

@semarie audited this struct definition.
@andrewrk
std.c.openbsd: add PTHREAD_STACK_MIN
479fd2f 
@semarie audited this definition.
@andrewrk
std.c.openbsd: remove "msg_" prefixes from structs
04d5e07 
Reapplies 8f14431 which was reverted in
95e2605.
@andrewrk andrewrk enabled auto-merge July 31, 2023 20:09
@andrewrk andrewrk merged commit 8f5c333 into master Jul 31, 2023
@andrewrk andrewrk deleted the audit-devnexen branch July 31, 2023 22:33
@ktiy ktiy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kprotty kprotty Awaiting requested review from kprotty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewrk