Skip to content

Sema: implement @errSetCast for error unions #17346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2023
Merged

Sema: implement @errSetCast for error unions #17346

merged 2 commits into from
Oct 1, 2023

Conversation

Vexu
Copy link
Member

@Vexu Vexu commented Oct 1, 2023

Closes #17343

@wooster0
Copy link
Contributor

wooster0 commented Oct 1, 2023 •
edited
Loading

Shouldn't it also be renamed to @errorCast? Error sets and error unions are two distinct things aren't they? I think a good way to sum it up is just calling it "error" hence @errorCast (and also not @errCast for consistency with the other builtin names that spell "error" out in full). Or should it be a separate builtin?

@Vexu Vexu force-pushed the errSetCast branch 3 times, most recently from 1fbe182 to d81b764 Compare October 1, 2023 12:09
@andrewrk andrewrk merged commit 8e1421f into ziglang:master Oct 1, 2023
@Vexu Vexu deleted the errSetCast branch October 1, 2023 19:23
@andrewrk
Copy link
Member

andrewrk commented Oct 1, 2023 •
edited
Loading

Follow-up work:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@errSetCast refuses to accept an error union operand
3 participants
@Vexu @wooster0 @andrewrk