wasm - fix bitcasting between arrays and scalar types #17819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrays are currently always passed by reference, this means that we always keep the value in linear memory and never load it to Wasm's stack. Scalar values however do get lowered to Wasm's stack. This means when bitcasting from an array to a scalar value, we must load the memory of the array as such scalar type. To bitcast a scalar type to an array, we allocate a new temporary in the linear data segment, and then store the scalar value there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was discovered by #17802, where in the Wasm backend it didn't correctly bitcast values between array and scalar types. This fixes that and re-enables the behavior tests as well as the default test-runner.