-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
change default WASI stack size #18971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dweiller
added a commit
to dweiller/zig
that referenced
this pull request
Feb 17, 2024
This commit can be reverted after ziglang#18971 is merged.
Hmm strange, the tests passed for me locally. |
andrewrk
pushed a commit
that referenced
this pull request
Feb 17, 2024
This commit can be reverted after #18971 is merged.
Different wasmtime versions maybe? |
andrewrk
pushed a commit
that referenced
this pull request
Feb 18, 2024
This commit can be reverted after #18971 is merged.
andrewrk
pushed a commit
that referenced
this pull request
Feb 20, 2024
This commit can be reverted after #18971 is merged.
andrewrk
pushed a commit
that referenced
this pull request
Feb 21, 2024
This commit can be reverted after #18971 is merged.
andrewrk
pushed a commit
that referenced
this pull request
Feb 22, 2024
This commit can be reverted after #18971 is merged.
andrewrk
pushed a commit
that referenced
this pull request
Feb 22, 2024
This commit can be reverted after #18971 is merged.
andrewrk
pushed a commit
that referenced
this pull request
Feb 23, 2024
This commit can be reverted after #18971 is merged.
andrewrk
pushed a commit
that referenced
this pull request
Feb 23, 2024
This commit can be reverted after #18971 is merged.
nope, both wasmtime v10.0.2 however, I was able to reproduce it by using |
found the problem: Lines 1141 to 1144 in 723d13f
|
to match the other operating systems. 16 MiB closes #18885
4744d94
to
4a2414b
Compare
RossComputerGuy
pushed a commit
to ExpidusOS-archive/zig
that referenced
this pull request
Mar 20, 2024
This commit can be reverted after ziglang#18971 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to match the other operating systems. 16 MiB
closes #18885