Skip to content

change default WASI stack size #18971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2024
Merged

change default WASI stack size #18971

merged 1 commit into from
Feb 26, 2024

Conversation

andrewrk
Copy link
Member

to match the other operating systems. 16 MiB

closes #18885

@andrewrk andrewrk mentioned this pull request Feb 17, 2024
dweiller added a commit to dweiller/zig that referenced this pull request Feb 17, 2024
This commit can be reverted after
ziglang#18971 is merged.
@andrewrk
Copy link
Member Author

Hmm strange, the tests passed for me locally.

andrewrk pushed a commit that referenced this pull request Feb 17, 2024
This commit can be reverted after
#18971 is merged.
@kubkon
Copy link
Member

kubkon commented Feb 18, 2024

Hmm strange, the tests passed for me locally.

Different wasmtime versions maybe?

andrewrk pushed a commit that referenced this pull request Feb 18, 2024
This commit can be reverted after
#18971 is merged.
andrewrk pushed a commit that referenced this pull request Feb 20, 2024
This commit can be reverted after
#18971 is merged.
andrewrk pushed a commit that referenced this pull request Feb 21, 2024
This commit can be reverted after
#18971 is merged.
andrewrk pushed a commit that referenced this pull request Feb 22, 2024
This commit can be reverted after
#18971 is merged.
andrewrk pushed a commit that referenced this pull request Feb 22, 2024
This commit can be reverted after
#18971 is merged.
andrewrk pushed a commit that referenced this pull request Feb 23, 2024
This commit can be reverted after
#18971 is merged.
andrewrk pushed a commit that referenced this pull request Feb 23, 2024
This commit can be reverted after
#18971 is merged.
@andrewrk
Copy link
Member Author

andrewrk commented Feb 26, 2024

Different wasmtime versions maybe?

nope, both wasmtime v10.0.2

however, I was able to reproduce it by using zig build test-std -fwasmtime

@andrewrk
Copy link
Member Author

found the problem:

zig/test/tests.zig

Lines 1141 to 1144 in 723d13f

if (target.os.tag == .wasi) {
// WASI's default stack size can be too small for some big tests.
these_tests.stack_size = 2 * 1024 * 1024;
}

to match the other operating systems. 16 MiB

closes #18885
@andrewrk andrewrk force-pushed the wasi-default-stack-size branch from 4744d94 to 4a2414b Compare February 26, 2024 07:16
@andrewrk andrewrk enabled auto-merge (rebase) February 26, 2024 07:16
@andrewrk andrewrk merged commit d51aa97 into master Feb 26, 2024
@andrewrk andrewrk deleted the wasi-default-stack-size branch February 26, 2024 18:33
RossComputerGuy pushed a commit to ExpidusOS-archive/zig that referenced this pull request Mar 20, 2024
This commit can be reverted after
ziglang#18971 is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failing std lib test: std.compress.deflate.deflate_fast.best speed match
2 participants