feat: add support for --enable-new-dtags and --disable-new-dtags #19042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nektro
approved these changes
Feb 22, 2024
andrewrk
approved these changes
Mar 6, 2024
|
Thanks @dmeijboom -- this fixes an issue affecting me, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18249
We're trying to use https://github.com/uber/hermetic_cc_toolchain as our C++ toolchain when building Rust applications. However, it seems like Rust uses the
--enable-new-dtagslinker flag which isn't supported by zig.I have no clue how to test these changes and I have no experience with Zig but with some feedback I'm sure we can get this wrapped up eventually.