package: remove git fetch zlib lookahead fix #19253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My first zlib implementation broke git fetch because it introduce [lookahead](ziglang#18967). That resulted in workarounds [1](ziglang@80f3ef6) [2](ziglang@d00faa2) After [fixing](ziglang#19163) lookahead in zlib decompressor this fixes are no longer necessary.
ianprime0509
approved these changes
Mar 11, 2024
|
@andrewrk |
|
Hmmmm. I could go either way with this one. I think generally, it would be better to leave such things to third party packages. It's more difficult to remove things than to add them later on, so better not to acquire too much std lib code right now. |
ianic
added a commit
to ianic/zig
that referenced
this pull request
Mar 20, 2024
Introduced in ziglang#19032 as a fix for ziglang#18967. Not needed any more after ziglang#19253.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first zlib implementation broke git fetch because it introduce lookahead. That resulted in workarounds 1 2.
After removing lookahead in zlib decompressor this fixes are no longer necessary.
cc @ianprime0509 for review