translate-c: support macro with 'assert(false && "error message")' #19610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes ziglang#14642 with modified fix suggested by @Vexu in ziglang#14642 (comment)
travisstaloch
force-pushed
the
translate-c-assert-strlit
branch
from
a3b400c to
7341d54
Compare
|
No idea why x86_64-windows-release failed https://github.com/ziglang/zig/actions/runs/8641722757/job/23691709128?pr=19610#step:3:79 Doesn't seem related to this PR. |
|
oic. it says above that chocolatey couldn't download ninja. thats why ninja couldn't be found. |
travisstaloch
added a commit
to travisstaloch/zig
that referenced
this pull request
Apr 11, 2024
this is a follow up to ziglang#19610 with fix suggested by @Vexu in ziglang#14642 (comment)
Vexu
pushed a commit
that referenced
this pull request
Apr 12, 2024
this is a follow up to #19610 with fix suggested by Vexu in #14642 (comment)
TUSF
pushed a commit
to TUSF/zig
that referenced
this pull request
May 9, 2024
this is a follow up to ziglang#19610 with fix suggested by Vexu in ziglang#14642 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14642 with modified fix suggested by @Vexu in #14642 (comment)