std.crypto: move rsa to separate module #19986
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure is a flake: |
19 tasks
|
@jedisct1 Ping. |
On vacation with GF who would kill me if I open the laptop. |
|
No problem, just been a couple weeks and I'm eager to get a good TLS server upstreamed. Enjoy your vacation! |
|
I'm not forgetting you. I'm gonna look at this asap. |
ianic
added a commit
to ianic/tls.zig
that referenced
this pull request
Jun 24, 2024
Copied from: https://github.com/clickingbuttons/zig/blob/f1cea91624fd2deae28bfb2414a4fd9c7e246883/lib/std/crypto/rsa.zig Hopefully clickingbuttons work will find a way to the std lib, or to separate rsa library. Things to watch: ziglang/zig#19776 ziglang/zig#19986
|
@jedisct1 Did you forget? ;) |
|
This needs a rebase to resolve the merge conflict. |
|
Fixed merge conflicts but didn't test since I have to rebuild LLVM. |
jedisct1
approved these changes
Oct 16, 2024
|
Where'd you go @jedisct1 ? :) |
|
Would you mind resolving the merge conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes. Side channel vulnerabilities are still present and a lot of future cleanup is still needed before making public.
Towards #19776. See #19771 (comment).