std.zig.system: use both PATH and hardcoded locations to find env
#21540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has a merge conflict that looks to stem from #21430. |
BratishkaErik
force-pushed
the
search-env-in-path
branch
from
a28605c to
914de5f
Compare
Thanks, fixed :) |
BratishkaErik
force-pushed
the
search-env-in-path
branch
from
914de5f to
12c2773
Compare
BratishkaErik
force-pushed
the
search-env-in-path
branch
from
12c2773 to
fa1e05c
Compare
Signed-off-by: Eric Joldasov <[email protected]>
Should help systems that have main `env` binary in different location than hardcoded `/usr/bin/env` **during build** (not neccessarily always), like Nix/Guix, Termux, Gentoo Prefix etc. Related: https://www.github.com/ziglang/zig/issues/12156 https://www.github.com/ziglang/zig/issues/14146 https://www.github.com/ziglang/zig/issues/14577 https://www.github.com/ziglang/zig/issues/15898 Source for logic: https://www.github.com/ziglang/zig/issues/14146#issuecomment-2308984936 Signed-off-by: Eric Joldasov <[email protected]>
BratishkaErik
force-pushed
the
search-env-in-path
branch
from
fa1e05c to
a79e421
Compare
|
Thanks. |
andrewrk
added
the
release notes
Closed
|
Reverted in 0bacb79 |
Fri3dNstuff
pushed a commit
to Fri3dNstuff/zig
that referenced
this pull request
Jan 27, 2025
…v-in-path" It caused an assertion failure when building Zig from source. This reverts commit 0595feb, reversing changes made to 744771d. closes ziglang#22566 closes ziglang#22568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help systems that have main
envbinary in different location than hardcoded/usr/bin/envduring build (not neccessarily always), like Nix/Guix, Termux, Gentoo Prefix etc.Theoretically should close following issues, but it needs more testing from affected users:
#12156
#14146
#14577
#15898
Source for logic: #14146 (comment)