fix: windows libc lib paths for x86-windows-msvc #22382
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix windows libc lib paths when compiling to
x86-windows-msvc
from ax86_64-windows
machine. The changes simply consider the cpu arch of the target instead of the host machine. This is what I get when outputting libc for targetx86-native-msvc
before this fix:As you can see the path for
crt_dir
andkernel32_lib_dir
ends with x64 which causes errors whenlld-link
links with system libraries (error: lld-link: libucrtd.lib(stream.obj): machine type x64 conflicts with x86
).I guess this is related to this issue #537?
FYI: I am new to zig. Let me know if there is a procedure for contribution. I don't see it anywhere