checkAllAllocationFailures: provide result type to 'extra_args' #23042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removal of anonymous struct types (#21817) has broken the following usage of
std.testing.checkAllAllocationFailures
:The signature of
checkAllAllocationFailures
looks like this:The parameter types of
test_fn
are not provided as result types toextra_args
which means that it will construct a "normal" struct type that won't be able to coerce to the@TypeOf(params)
which will cause a compile error similar to this:This fix should also improve the compile error messages if the provide extra arguments are incorrect because the validation is performed at the callsite instead of inside of the
checkAllAllocationFailures
function.I have also tested this fix with https://github.com/ziglibs/diffz which frequently uses this code pattern in its tests.