Some hexagon-linux porting work
#23497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🟢 Green light from me. I don't think I would personally find the time to maintain this, but if you're willing to, great! |
This is from Qualcomm's fork: https://github.com/quic/musl I maintain a fork of musl where I rebase Qualcomm's changes on top of the latest musl release, which I then use as the basis for musl updates in Zig. My fork can be found here: https://github.com/alexrp/musl/tree/hexagon
Most of the failures are: * llvm/llvm-project#118879 * llvm/llvm-project#134659 But some are also miscompilations leading to wrong results. I'm not going to investigate the latter further until all the backend crashes have been resolved.
This skips std tests for now: llvm/llvm-project#111217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
hexagon-linux#21652 (comment)).hexagon-linux-(none,musl)to the test matrix withstdtests disabled for now.@andrewrk if you're okay with integrating Qualcomm's fork in this way, I'll update the instructions to show how that fork can be rebased on top of a musl release and included in Zig with very little effort. As a reminder, this is only a temporary solution until the fork is upstreamed, with the only limiting factor there AFAIK being Rich Felker finding time to review it.