inline assembly: enable GCC's %=
syntax
#23740
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC uses the
%=
syntax to generate a unique number for eachasm
statement (see on gcc's docs). LLVM uses${:uid}
to do the same.This PR adds the syntax, since it is not currently possible to use
%=
or${:uid}
in zig's inline assembly. Also, it is currently impossible to use${:comment}
or${:private}
described here on llvm's docs, and this PR does not change that.I am unsure if this change requires tests, and how to even test it.