Rename --glibc-runtimes to --libc-runtimes and make it work with musl; add more targets to the module test matrix
#23810
+378
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of these are gated by -Dtest-extra-targets because:
* We don't really have CI resources to spare at the moment.
* They're relatively niche if you're not on a musl distro.
* And the few musl distros that exist don't support all these targets.
* Quite a few of them are broken and need investigating.
x86_64-linux-musl and aarch64-linux-musl are not gated as they're the most
common targets that people will be running dynamic musl on, so we'll want to
have some bare minimum coverage of those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--glibc-runtimesis now called--libc-runtimesas it now also works for dynamic musl. (--glibc-runtimesis still accepted for compatibility, but it won't show up in--help.) I've written a wiki page with copy-pastable scripts for building glibc and musl for (almost) all supported targets: https://github.com/ziglang/zig/wiki/Building-multiple-libcs-for-testing-Dtest-extra-targetsmainly because we only have so much CI time to work with.x86_64-linux-muslandaarch64-linux-muslare not gated because they're the most common platforms that dynamic musl will be used on, so we'll want to have some bare minimum coverage of those.-Dtest-extra-targets.