Skip to content

make error messages prettier #23829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make error messages prettier #23829

wants to merge 1 commit into from
+7 −7

Conversation

wooster0
Copy link
Contributor

@wooster0 wooster0 commented May 8, 2025

  1. Error messages never contain periods or grave accents. Get rid of the periods and use apostrophes instead in probably the only two error messages that had them.
  2. Change T to Type. It looks like something taken from languages like Rust that by convention use single letters for type parameter names. Zig doesn't need that.

@alexrp alexrp requested a review from mlugg May 8, 2025 06:07
mlugg
mlugg reviewed May 8, 2025
View reviewed changes
Copy link
Member

@mlugg mlugg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine.

@wooster0
make error messages prettier
92cbdd4 
Error messages never contain periods or grave accents.
Get rid of the periods and use apostrophes instead in
probably the only two error messages that had them.
@wooster0
Copy link
Contributor Author

Looks like the CI for aarch64-linux timed out? Everything else passed so is this fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlugg mlugg mlugg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wooster0 @mlugg