WIP: Add arm interrupt calling conventions #2387
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this conflicts with the changes proposed in #661. |
|
It does, but Andrew has said he would accept patches that are workarounds
for other things in the meantime until the official plan is implemented.
I think this is a reasonable patch for now so I can keep fleshing out the
arm side of Zig. You can't do much without interrupts...
If it's rejected then I'll just have to start working on that other one.
…On Tue, Apr 30, 2019, 4:50 PM emekoi ***@***.***> wrote:
this conflicts with the changes proposed in #661
<#661>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2387 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJOF5C7WOODDQ62IRTEMHHLPTC5KFANCNFSM4HJPCCCA>
.
|
|
Why waste time updating all the other things? I'll just try to work on the other issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to update the grammar, docs, tokenizer in std lib, zig fmt, etc.
Besides those things, does this look alright? I think it makes sense to have these be calling conventions. Clang and GCC use attributes but that doesn't already exist in Zig and Zig doesn't use something akin to attributes for
linksection, it just has that as a keyword.I couldn't think of any compile errors that were necessary to add, nor am I sure what kind of tests to add and where?