More more builtins #2452
Merged
More more builtins #2452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add their AEABI aliases, __aeabi_i2f & __aeabi_i2d
Add AEABI builtin __aeabi_d2f
Add AEABI builtins __aeabi_ul2d, __aeabi_ui2d
Add AEABI builtin __aeabi_l2d
Add AEABI builtin __aeabi_f2d
|
Nice! I think this is most of the work to adding |
Done ;) |
daurnimator
reviewed
May 8, 2019
| testing.expect(r == expected); | ||
| } | ||
|
|
||
| test "floatdidf" { |
There was a problem hiding this comment.
Why is this test in a separate file? While e.g. floatsiXf has tests in the same file?
There was a problem hiding this comment.
There's a precedent for having them in a separate file to save space of the shipped .zig files. However it's not required.
There was a problem hiding this comment.
I don't mind either way, I just think it should be consistent.
There was a problem hiding this comment.
I try to put long test cases in a separate file and keep short ones at the bottom of the file where the implementation is.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another day, another dump.