Optimize file splatting on Windows, Darwin and Haiku #24784
+69
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilmaria
force-pushed
the
optimize-windows-file-splatting
branch
from
39cd230 to
b2c861c
Compare
|
I don't know what is causing the test failures. Locally testing, this seemd to work on x86_64-windows and x86_64-linux. |
|
looks like something that was fixed by b9a6dae so you should be able to rebase to solve it |
ilmaria
force-pushed
the
optimize-windows-file-splatting
branch
2 times, most recently
from
7974103 to
72a1806
Compare
ilmaria
changed the title
|
Darwin and Haiku also had the same issue as Windows because |
ilmaria
force-pushed
the
optimize-windows-file-splatting
branch
from
9968971 to
701bf82
Compare
|
I now realized that testing this through File.Writer's public API is not actually sensible since we cannot guarantee that a single write call will write all given bytes. If we wanted to test this splat optimization, we would need to test that File.Writer internally avoids calling write with small buffers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24783