Skip to content

std.Build: do not override properties of a package like named modules #24879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

std.Build: do not override properties of a package like named modules #24879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions lib/std/Build.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,7 +906,13 @@ pub const AssemblyOptions = struct {
/// `createModule` can be used instead to create a private module.
pub fn addModule(b: *Build, name: []const u8, options: Module.CreateOptions) *Module {
const module = Module.create(b, options);
b.modules.put(b.dupe(name), module) catch @panic("OOM");
const gop = b.modules.getOrPutValue(b.dupe(name), module) catch @panic("OOM");
if (gop.found_existing) {
panic(
"A module with the name '{s}' has already been added to the package. Consider creating a private module with std.Build.createModule",
.{name},
);
}
return module;
}

Expand Down Expand Up @@ -1025,12 +1031,24 @@ pub fn addWriteFile(b: *Build, file_path: []const u8, data: []const u8) *Step.Wr

pub fn addNamedWriteFiles(b: *Build, name: []const u8) *Step.WriteFile {
const wf = Step.WriteFile.create(b);
b.named_writefiles.put(b.dupe(name), wf) catch @panic("OOM");
const gop = b.named_writefiles.getOrPutValue(b.dupe(name), wf) catch @panic("OOM");
if (gop.found_existing) {
panic(
"A WriteFile step with the name '{s}' has already been added to the package. Consider creating a private WriteFile step with std.Build.addWriteFiles",
.{name},
);
}
return wf;
}

pub fn addNamedLazyPath(b: *Build, name: []const u8, lp: LazyPath) void {
b.named_lazy_paths.put(b.dupe(name), lp.dupe(b)) catch @panic("OOM");
const gop = b.named_lazy_paths.getOrPutValue(b.dupe(name), lp) catch @panic("OOM");
if (gop.found_existing) {
panic(
"A LazyPath with the name '{s}' has already been added to the package.",
.{name},
);
}
}

pub fn addWriteFiles(b: *Build) *Step.WriteFile {
Expand Down