std lib test suite: fix some illegal behavior found by valgrind #24906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
requested changes
Aug 19, 2025
it isn't necessary for the test and triggered a valgrind warning
…UEUE fixes a valgrind warning
…re buffer fixes a valgrind warning
the buffers are set to 0 after reading provide_buffers: triggered when checking cqe.user_data remove_buffers: expectEqualSlices
…y fix valgrind warning
disabling the false positive warning is a bit tricky
CorruptedVor
commented
Aug 19, 2025
| @@ -3338,6 +3343,7 @@ test "remove_buffers" { | |||
| const buffer_len = 128; | |||
|
|
|||
| var buffers: [4][buffer_len]u8 = undefined; | |||
| std.valgrind.memcheck.makeMemDefinedIfAddressable(std.mem.sliceAsBytes(&buffers)); | |||
There was a problem hiding this comment.
Should I move this to around 3392, after ring.copy_cqe()? that is when it should be defined, not right here
(if that was not the case the check for a zero-initialized later would fail)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up on #24833 - without a fix for Build.zig
I can also split this pr up into several prs, if that makes it easier