-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Std interface reform simple: unified #2582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
tgschultz
wants to merge
38
commits into
ziglang:master
from
tgschultz:stdlib-interface_reform_simple_unified
Closed
Std interface reform simple: unified #2582
tgschultz
wants to merge
38
commits into
ziglang:master
from
tgschultz:stdlib-interface_reform_simple_unified
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please see #130 (comment). I'm closing this pull request because it's not really mergable, but I do consider it to be an invaluable tool in evaluating how to proceed with that issue, once the time comes to do that. 👍 Thank you @tgschultz! (I'm going to copy this comment to the other 2 pull requests, for the benefit of anyone stumbling upon them.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variation of interface reform is identical to #2553 except that it also removes the dynamic ErrorSets of the Stream interface, unifying the all stream types into a single type with a single ErrorSet.