[Waiting on other PRs] Add the no-extension case to windows program search #2770
Conversation
std/child_process.zig
Outdated
| }; | ||
| } | ||
| pub fn next(self: *@This()) @typeOf(T.next).ReturnType { | ||
| return if (self.onU) self.u.next() else self.t.next(); |
There was a problem hiding this comment.
When do you set .onU to true?
There was a problem hiding this comment.
in a follow-up commit :)
marler8997
force-pushed
the
windowsNoExt
branch
3 times, most recently
from
9966266 to
1c220e6
Compare
| @@ -768,3 +770,47 @@ pub fn createWindowsEnvBlock(allocator: *mem.Allocator, env_map: *const BufMap) | |||
| i += 1; | |||
| return allocator.shrink(result, i); | |||
| } | |||
|
|
|||
| // TODO: does this already exist somewhere? | |||
| fn Chain(comptime T: type, comptime U: type) type { | |||
There was a problem hiding this comment.
Note that this (and the OneItemIterator) should either be moved somewhere else before merging, or they need to be removed if there is something else in the standard library that already provides this.
I'm not familiar enough with the standard library to know if these already exist somewhere in some form.
|
It's not needed since you'll get a compile error. Checking it might give you an opportunity to provide a nicer error message, but the check might not be simple since they don't need to be the same. Right now |
marler8997
changed the title
|
Feel free to re-open when this is ready for review |
Waiting on the status of #2777 and #2782