Prevent unreachable when file ends with struct field #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

andrewrk merged 1 commit into ziglang:master from hryx:tiny-file-unreachable

Jul 6, 2019

Contributor

hryx commented Jul 5, 2019 •

edited

Loading

Fixes #2813

To demystify the original example program which triggers the problem:

This is grammatically valid and means "top-level struct field with no type or default value defined".

ContainerField <- IDENTIFIER (COLON TypeExpr)? (EQUAL Expr)?

This behavior was also triggered with the new test case:

a: bool

The renderer incorrectly assumed the number of remaining tokens in the file after the field.


          Prevent unreachable when file ends with struct field

758f622

andrewrk merged commit 7f61818 into ziglang:master

Member

andrewrk commented Jul 6, 2019

Thanks! Related issue: #2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet