[WIP #3844 #3767] update std.c and std.os.linux functions to use null-terminated pointer types #3899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulgrell
commented
Dec 13, 2019
lib/std/c.zig
Outdated
| pub extern "c" fn symlink(existing: [*:0]const u8, new: [*:0]const u8) c_int; | ||
| pub extern "c" fn rename(old: [*:0]const u8, new: [*:0]const u8) c_int; | ||
| pub extern "c" fn chdir(path: [*:0]const u8) c_int; | ||
| pub extern "c" fn execve(path: [*:0]const u8, argv: [*:0]const ?[*]const u8, envp: [*:0]const ?[*]const u8) c_int; |
There was a problem hiding this comment.
Should this be:
pub extern "c" fn execve(path: [:0]const u8, argv: [:0]const ?[]const u8, envp: [:0]const ?[]const u8) c_int;
or
pub extern "c" fn execve(path: [:0]const u8, argv: [:0]const [:0]const u8, envp: [:0]const [:0]const u8) c_int;
There was a problem hiding this comment.
I think you want something like this:
pub extern "c" fn execve(path: [:0]const u8, argv: [*:null]const ?[*:0]const u8, envp: [*:null]const ?[*:0]const u8) c_intThat is, an "array" of null-terminated strings, where the last string is always null.
|
You might have to fix some callsites, which may involve some |
|
I'm going through the corresponding function in std.os.linux - I'll make sure it's all updated. It should eventually close #3767 |
raulgrell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shoutout to @stratact for the first attempt!
I'm fairly confident the signatures are correct. Are there any tests that need to be created?
Closes #3884