-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[#3844 + #3767] update std.c and std.os.linux to use null-terminated pointer types #3900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ede22fc
to
5985d8f
Compare
Thanks to @tiehuis for also pointing me to the right signature for execve. EDIT: Let me know if I should squash the commits |
Thanks for the speedy review. In one commit, I left the port cast in. In the next, I added a allocPrintCstr function that returns a null terminated slice. Not sure it's in the right place or if it's the best name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Still WIP? |
No longer WIP! |
Resubmitting the pull request in a separate branch, and as a draft. Apologies for the clutter.
I wasn't sure how to handle the execve function.
Thanks to @fengb I settled on