Fix translation of signed array indices #4113
Conversation
travisstaloch
commented
Jan 8, 2020
travisstaloch
commented
- Closes translate-c doesn't cast signed array index #4075
|
It is likely easier on everyone to get rid of that bad rebase/merge attempt from #4079 now. Please bear with me as I sometimes struggle with git. I'm a little rusty and currently focusing on making this a better experience. I didn't mean to close the last PR, but deleting those commits triggered it. Hope this is better. |
|
😊 Annnd I'm hoping the third time is a charm. Once again didn't mean to close another pull request. Now I know not to force push on a PR. 🐑 |
src-self-hosted/translate_c.zig
Outdated
| @@ -363,7 +363,7 @@ fn prepopulateGlobalNameTable(ast_unit: *ZigClangASTUnit, c: *Context) !void { | |||
| } | |||
| } | |||
|
|
|||
| fn declVisitorNamesOnlyC(context: ?*c_void, decl: *const ZigClangDecl) callconv(.C) bool { | |||
There was a problem hiding this comment.
I thought this might be causing CI test failures on windows/macos. This doesn't seem to be the case.
|
These windows/macos CI failures seem to be on test-run-translated-c. I think they're a result of using assert.h as observed in #4101. |
test/run_translated_c.zig
Outdated
|
|
||
| cases.add("cast signed array index to unsigned", | ||
| \\#include <stdlib.h> | ||
| \\#define _NO_CRT_STDIO_INLINE 1 |
There was a problem hiding this comment.
You don't need this workaround unless using stdio.h and printf.
There was a problem hiding this comment.
Removed #define _NO_CRT_STDIO_INLINE 1s
don't worry about it, no big deal. I'm not sure what problem you ran into, but you can force push a branch that is a pull request, it should work fine. |
test/run_translated_c.zig
Outdated
|
|
||
| cases.add("cast signed array index to unsigned", | ||
| \\#include <stdlib.h> | ||
| \\void main(int argc, char **argv) { |
There was a problem hiding this comment.
I believe using void main rather than int main makes your exit code undefined. Better would be to use c_int and return 0 like the other tests do.
There was a problem hiding this comment.
good catch. done.
|
Not sure if you already did, but it would be nice to print the failing test name in test/translate_c.zig as well as test/run_translated_c.zig. |
|
That's done in 4e4ba6c; if this PR is rebased against that commit or later then it will be so |
|
Nice work! |
|
Thanks 👍 Thanks for being patient with my git foibles. |
