Skip to content

std.crypto.gimli enhancements #4369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 5, 2020
Merged

std.crypto.gimli enhancements #4369

merged 3 commits into from
Feb 5, 2020

Conversation

daurnimator
Copy link
Contributor

  • Add std.mem.secureEqual
  • Add code for AEAD mode
  • Have crypto hash benchmark include gimli

@daurnimator daurnimator added enhancement Solving this issue will likely involve adding new logic or components to the codebase. standard library This issue involves writing Zig code for the standard library. labels Feb 2, 2020
andrewrk
andrewrk requested changes Feb 2, 2020
View reviewed changes
Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enhancements to Gimli seem fine to me. However I don't think it is currently possible to write a constant time equality function in Zig without inline assembly.

@andrewrk andrewrk merged commit 5cf30b6 into ziglang:master Feb 5, 2020
@daurnimator daurnimator deleted the gimli branch February 5, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewrk andrewrk andrewrk requested changes

Assignees
No one assigned
Labels
enhancement Solving this issue will likely involve adding new logic or components to the codebase. standard library This issue involves writing Zig code for the standard library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daurnimator @andrewrk