Take advantage of mem.spanZ accepting null #4880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doh; looks like #4858 was broken! I'll add a fix to this PR. |
daurnimator
commented
Mar 31, 2020
| const zig_triple = if (zig_triple_oz) |zig_triple_z| mem.spanZ(zig_triple_z) else "native"; | ||
| const mcpu = if (mcpu_oz) |mcpu_z| mem.spanZ(mcpu_z) else null; | ||
| const dynamic_linker = if (dynamic_linker_oz) |dl_z| mem.spanZ(dl_z) else null; | ||
| const mcpu = mem.spanZ(mcpu_oz); |
There was a problem hiding this comment.
Fun bug: if I inlined this into the following expression I got:
broken LLVM module found: Call parameter type does not match function signature!
%67 = getelementptr inbounds %std.zig.cross_target.ParseOptions, %std.zig.cross_target.ParseOptions* %10, i32 0, i32 1, !dbg !20878
%"?[:0]const u8"* call fastcc void @std.mem.spanZ.176(%"?[]const u8"* sret %67, i8* %68), !dbg !20880
This is a bug in the Zig compiler.
|
the freebsd tests should be a good enough test here. other ones failed because of bad timing with a broken master branch commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tidy up I had around that can be upstreamed since #4858 was merged.