Skip to content

Fix missing compile error on assign to slice and array parameters #4975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2020
Merged

Fix missing compile error on assign to slice and array parameters #4975

merged 2 commits into from
Apr 9, 2020

Conversation

Vexu
Copy link
Member

@Vexu Vexu commented Apr 7, 2020 •
edited
Loading

Compile errors on structs and arrays point to the first element which makes me doubt how correct this fix is.

Closes #3800
Closes #4350
Closes #4015

@Vexu Vexu force-pushed the param-reassign branch from e3e0af6 to b1e44ad Compare April 8, 2020 11:39
@andrewrk
Copy link
Member

andrewrk commented Apr 9, 2020

Beautiful

@andrewrk andrewrk merged commit beae932 into ziglang:master Apr 9, 2020
@Vexu Vexu deleted the param-reassign branch April 9, 2020 03:43
@Vexu Vexu mentioned this pull request Apr 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Vexu @andrewrk