std: add fmt option to escape non-printable characters #6218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daurnimator
added
the
standard library
This comment has been minimized.
This comment has been minimized.
daurnimator
force-pushed
the
fmt-non-printable
branch
from
7104301 to
90b1aed
Compare
Vexu
reviewed
Aug 31, 2020
| @@ -599,6 +600,16 @@ pub fn formatText( | |||
| try formatInt(c, 16, fmt[0] == 'X', FormatOptions{ .width = 2, .fill = '0' }, writer); | |||
| } | |||
| return; | |||
| } else if (comptime (std.mem.eql(u8, fmt, "e") or std.mem.eql(u8, fmt, "E"))) { | |||
| for (bytes) |c| { | |||
| if (std.ascii.isPrint(c)) { | |||
There was a problem hiding this comment.
Do we consider \t, \n and \r printable? (#4014)
There was a problem hiding this comment.
For purposes of a debug print: I don't think they should be considered printable:
- its hard to visually tell the difference between a tab that is one space wide an a normal space character.
- I imagine this would often be used for line based output, where escaping newlines is desired.
\ris unprintable
andrewrk
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.