-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
More std.fmt goodness #6411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More std.fmt goodness #6411
Conversation
Maybe use try testFmt("hello world!", "{@greeting @who!}", .{ .greeting = "hello", .who = "world" }); |
I wouldn't use |
and |
I guess so? I just think we should treat compiler builtins as quite special and thus not use the |
Hmm, the Windows failure looks legit... Can anyone pinpoint where (and/or on what file) it's crashing? |
I feel like the description is just a test to see who will read it till the end? |
Seems like a good idea 👍🏻 |
I don't think the issue is caused by this branch - I'm seeing a similar failure in master. I suspect 0f31113 |
can you try rebasing to after f8b3543 ? |
Done, but the failure's still there :( |
I'll help with this eventually, but I do want to focus on my branch #6250 until it's done |
This will be very nice to have for code generation in zig-wayland. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with merging this as-is. Mind dealing with the conflict(s)?
Turn the FSM parser into a linear one so that's easier to implement new features and/or more error checking without adding more and more states. Functionally-speaking the two parsers are at feature parity.
I'm pushing this branch so you can give it a spin to make sure there are no regressions and, if possible, find an answer to a few open questions.
The good
comptime
seems to work, stage1 didn't catch fire{[NAME]}
or{[POSITION]}
)The bad
The ugly
{N}
and{[N]}
for referring to the N-th parameter. Is this unacceptable and discusting? Is this fine?[]
?There's no specifier to tell the width/precision is taken from the following argument, do we want that?