Skip to content

Comply with semantic versioning pre-release format #6509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

jayschwa
Copy link
Contributor

@jayschwa jayschwa commented Oct 2, 2020

Example version: 0.8.0-dev.460+g81b343a16

From a semantic versioning perspective, development builds will now be
considered distinct from a tagged release. The number of commits added
since the last tag is included in the pre-release component.

Updates #6466

@jayschwa jayschwa added this to the 0.7.0 milestone Oct 2, 2020
@andrewrk
Copy link
Member

andrewrk commented Nov 6, 2020

I wanted to get this (and #6566) in by 0.7.0 but ran out of time to do it early enough to do due diligence to fix possible breakage from this change. So I'm sorry to do this but I don't think we're going to have this feature in 0.7.0. This will be another "unstable" release, with no 0.7.1 planned. But after 0.8.0 it's planned to have bug fix releases after that, so that would be the time to have some semblance of stability.

@andrewrk andrewrk removed this from the 0.7.0 milestone Nov 6, 2020
Example version: 0.8.0-dev.460+g81b343a16

From a semantic versioning perspective, development builds will now be
considered distinct from a tagged release. The number of commits added
since the last tag is included in the pre-release component.

Updates ziglang#6466
@jayschwa
Copy link
Contributor Author

Rebased and tweaked for 0.8.0 development.

@andrewrk
Copy link
Member

Thanks @jayschwa!

@andrewrk andrewrk merged commit bbe2cca into ziglang:master Dec 29, 2020
@jayschwa jayschwa deleted the semver-prerelease branch December 29, 2020 22:28
@jayschwa
Copy link
Contributor Author

jayschwa commented Dec 30, 2020

Thanks for merging. While starting on the final step of proposal #6466, I noticed that I may have missed some parallel Git parsing and version construction logic in the repo's top level build.zig. I will try to figure it out and hopefully have a follow up PR soon.

jayschwa added a commit to jayschwa/zig that referenced this pull request Dec 30, 2020
This matches the behavior of CMake builds. These changes should have
gone in with PR ziglang#6509, but were missed.
jayschwa added a commit to jayschwa/zig that referenced this pull request Dec 30, 2020
This matches the behavior of CMake builds. These changes should have
gone in with PR ziglang#6509, but were missed.
jayschwa added a commit to jayschwa/zig that referenced this pull request Dec 30, 2020
This matches the behavior of CMake builds. These changes should have
been in PR ziglang#6509, but were missed.
jayschwa added a commit to jayschwa/zig that referenced this pull request Dec 30, 2020
This matches the behavior of CMake builds. These changes should have
been in PR ziglang#6509, but were missed.
jayschwa added a commit to jayschwa/zig that referenced this pull request Dec 30, 2020
This matches the behavior of CMake builds. These changes should have
been in PR ziglang#6509, but were missed.
@jayschwa jayschwa mentioned this pull request Jan 1, 2021
jayschwa added a commit to jayschwa/zig that referenced this pull request Jan 1, 2021
`git describe` is used for version string creation, but it had to be
reverted in commit 69da6ba because it was broken in CI builds.
Azure Pipelines and Drone perform shallow clones by default.
This change reconfigures them to do normal clones and fetch tags.
This adds an extra 10-20 seconds, which is negligible compared to
overall build and test time.

Related: ziglang#6466, ziglang#6509, ziglang#7601
jayschwa added a commit to jayschwa/zig that referenced this pull request Jan 1, 2021
git describe is used for version string creation, but it had to be
reverted in commit 69da6ba because it was broken in CI builds.
Azure Pipelines and Drone perform shallow clones by default.
This change reconfigures them to fetch history and tags. It adds tens of
seconds, which is negligible compared to overall build and test time.

Related: ziglang#6466, ziglang#6509, ziglang#7601
jayschwa added a commit to jayschwa/zig that referenced this pull request Jan 2, 2021
git describe is used for version string creation, but it had to be
reverted in commit 69da6ba because it was broken in CI builds.
Azure Pipelines and Drone perform shallow clones by default.
This change reconfigures them to fetch history and tags. It adds tens of
seconds, which is negligible compared to overall build and test time.

Related: ziglang#6466, ziglang#6509, ziglang#7601
andrewrk pushed a commit that referenced this pull request Jan 2, 2021
git describe is used for version string creation, but it had to be
reverted in commit 69da6ba because it was broken in CI builds.
Azure Pipelines and Drone perform shallow clones by default.
This change reconfigures them to fetch history and tags. It adds tens of
seconds, which is negligible compared to overall build and test time.

Related: #6466, #6509, #7601
aarvay pushed a commit to aarvay/zig that referenced this pull request Jan 4, 2021
This matches the behavior of CMake builds. These changes should have
been in PR ziglang#6509, but were missed.
aarvay pushed a commit to aarvay/zig that referenced this pull request Jan 4, 2021
git describe is used for version string creation, but it had to be
reverted in commit 69da6ba because it was broken in CI builds.
Azure Pipelines and Drone perform shallow clones by default.
This change reconfigures them to fetch history and tags. It adds tens of
seconds, which is negligible compared to overall build and test time.

Related: ziglang#6466, ziglang#6509, ziglang#7601
dgbuckley pushed a commit to dgbuckley/zig that referenced this pull request Mar 9, 2021
This matches the behavior of CMake builds. These changes should have
been in PR ziglang#6509, but were missed.
dgbuckley pushed a commit to dgbuckley/zig that referenced this pull request Mar 9, 2021
git describe is used for version string creation, but it had to be
reverted in commit 69da6ba because it was broken in CI builds.
Azure Pipelines and Drone perform shallow clones by default.
This change reconfigures them to fetch history and tags. It adds tens of
seconds, which is negligible compared to overall build and test time.

Related: ziglang#6466, ziglang#6509, ziglang#7601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants