Skip to content

fix #6552 #6553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix #6552 #6553

wants to merge 1 commit into from

Conversation

codehz
Copy link
Contributor

@codehz codehz commented Oct 4, 2020

use libX.a for any-windows-gnu target

@codehz
fix ziglang#6552
6ad2c2a 
use libX.a for any-windows-gnu target
@codehz
Copy link
Contributor Author

codehz commented Oct 4, 2020

Oh, it is not enough, please convert into draft

@alexnask alexnask marked this pull request as draft October 4, 2020 14:04
@alexnask alexnask added the frontend Tokenization, parsing, AstGen, Sema, and Liveness. label Oct 4, 2020
@codehz
Copy link
Contributor Author

codehz commented Oct 4, 2020 •
edited
Loading

@alexnask It actually works, I forgot to clear the zig-cache(30 minutes wasted)...

@codehz codehz marked this pull request as ready for review October 4, 2020 14:43
@codehz
Copy link
Contributor Author

codehz commented Oct 4, 2020

The ci failed seems caused by another reason

@IridescentRose
Copy link
Contributor

IridescentRose commented Oct 5, 2020 •
edited
Loading

Reading some of the logs, it looks like the CI failed to link against libc for windows on other platforms (cross build).

@andrewrk andrewrk self-assigned this Oct 5, 2020
andrewrk added a commit that referenced this pull request Oct 5, 2020
@andrewrk
build system: implement computeOutFilenames using std.zig.binNameAlloc
33bc1eb 
See #6552 #6553 #6483

Also fixes a regression introduced in
1d777e9 of not converting an integer to
a string for a command line parameter.
@andrewrk
Copy link
Member

Fixed by 33bc1eb

@andrewrk andrewrk closed this Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andrewrk andrewrk

Labels
frontend Tokenization, parsing, AstGen, Sema, and Liveness.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codehz @IridescentRose @andrewrk @alexnask